Skip to content

tls: move _tls_* to end-of-life #60658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bjohansebas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tls: move _tls_* to end-of-life #60658

bjohansebas wants to merge 1 commit into from
+6 −55

Conversation

@bjohansebas
Copy link
Member

@bjohansebas bjohansebas commented Nov 9, 2025

So that in Node.js 26 these modules are no longer there, and are now internal to Node.js only instead of public.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 9, 2025

Review requested:

  • @nodejs/startup
  • @nodejs/userland-migrations

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. tls Issues and PRs related to the tls subsystem. labels Nov 9, 2025
@bjohansebas
Copy link
Member Author

bjohansebas commented Nov 9, 2025

cc: @nodejs/tsc since it’s an end-of-life deprecation

@bjohansebas bjohansebas added semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels Nov 9, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.51%. Comparing base (4f24aff) to head (b913f6e).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60658      +/-   ##
==========================================
- Coverage   88.53%   88.51%   -0.02%     
==========================================
  Files         703      701       -2     
  Lines      208546   208523      -23     
  Branches    40217    40219       +2     
==========================================
- Hits       184634   184580      -54     
- Misses      15926    15962      +36     
+ Partials     7986     7981       -5
Files with missing lines Coverage Δ
lib/internal/main/mksnapshot.js 95.83% <ø> (-0.04%) ⬇️
src/node_builtins.cc 76.28% <ø> (-0.19%) ⬇️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjohansebas
Copy link
Member Author

bjohansebas commented Dec 18, 2025

cc @nodejs/crypto @nodejs/net

@pimterry pimterry added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2025
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 19, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 19, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70530/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 20, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70556/

@bjohansebas
Copy link
Member Author

bjohansebas commented Dec 27, 2025

It looks flaky in GitHub Actions CI. Could someone rerun it, please?

@bjohansebas
Copy link
Member Author

bjohansebas commented Dec 27, 2025

Should I do a rebase to see if it’s still failing?

@aduh95
Copy link
Contributor

aduh95 commented Dec 27, 2025 •
edited
Loading

Should I do a rebase to see if it’s still failing?

That wouldn't help (unless a fix for the flakiness had landed on main since last commit, but AFAIK that's not the case), and force us to re-review and re-run all CI jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pimterry pimterry pimterry approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

+1 more reviewer

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. deprecations Issues and PRs related to deprecations. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bjohansebas @nodejs-github-bot @aduh95 @pimterry @RafaelGSS @AugustinMauroy